Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iox-#2325 support bzlmod #2338

Merged
merged 10 commits into from
Sep 9, 2024
Merged

iox-#2325 support bzlmod #2338

merged 10 commits into from
Sep 9, 2024

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Aug 26, 2024 •
edited by elBoberido
Loading

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@wep21 wep21 mentioned this pull request Aug 26, 2024
Closed
21 tasks
@elBoberido
Copy link
Member

elBoberido commented Aug 26, 2024 •
edited
Loading

@wep21 wow, this was fast. Thanks very much for taking care of this.

We have still users who are relying on the old WORKSPACE approach so we might need to restore some of the deleted files for the time being.

I'll check whether the users I know of are able to use dependencies which use bzlmod. If this is indeed the case, this can be merged as is (once the CI is green), if not the files from the bazel folder need to be restored.

Anyway, it's is great to move this forward :)

Edit: It seems that there are some issues with //:buildifier_lint_check

@wep21
Copy link
Contributor Author

wep21 commented Aug 26, 2024

@elBoberido

I'll check whether the users I know of are able to use dependencies which use bzlmod. If this is indeed the case, this can be merged as is (once the CI is green), if not the files from the bazel folder need to be restored.

I restored old files once and added WORKSPACE.bzlmod for compatibility.

Edit: It seems that there are some issues with //:buildifier_lint_check

Let me check the error.

@codecov Codecov
Copy link

codecov bot commented Aug 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.23%. Comparing base (bf4e66a) to head (417eaba).
Report is 36 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2338   +/-   ##
=======================================
  Coverage   78.22%   78.23%           
=======================================
  Files         433      433           
  Lines       16034    16033    -1     
  Branches     2302     2299    -3     
=======================================
  Hits        12543    12543           
- Misses       2644     2647    +3     
+ Partials      847      843    -4
Flag Coverage Δ
unittests 78.05% <ø> (+<0.01%) ⬆️
unittests_timing 15.06% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 17 files with indirect coverage changes

wep21
wep21 commented Aug 27, 2024
View reviewed changes
BUILD.bazel Outdated Show resolved Hide resolved
elBoberido
elBoberido reviewed Aug 27, 2024
View reviewed changes
BUILD.bazel Outdated Show resolved Hide resolved
MODULE.bazel Outdated Show resolved Hide resolved
@wep21 wep21 requested a review from elBoberido August 27, 2024 14:20
@wep21 wep21 requested a review from elBoberido August 28, 2024 18:22
elBoberido
elBoberido previously approved these changes Sep 8, 2024
View reviewed changes
@elBoberido
Copy link
Member

Just wanted to merge but then I noticed that there is no entry in the changelig.

Can you please add an entry to the feature section of doc/website/release-notes/iceoryx-unreleased.md. The format is the name of the issue which is fixed and the link to the issue.

@wep21
Copy link
Contributor Author

wep21 commented Sep 8, 2024

Can you please add an entry to the feature section of doc/website/release-notes/iceoryx-unreleased.md. The format is the name of the issue which is fixed and the link to the issue.

added at 417eaba

elBoberido
elBoberido approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wep21 thanks for your contribution and your patience. If you like to continue with bazel, there is some work on iceoryx2 which we could look at.

@elBoberido elBoberido merged commit 56ff256 into eclipse-iceoryx:main Sep 9, 2024
26 checks passed
@wep21 wep21 deleted the iox-2325-bzlmod branch September 9, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elBoberido elBoberido elBoberido approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port iceoryx to bzlmod
2 participants
@wep21 @elBoberido